Update support for weak references #2248
Conversation
This commit updates the `WASM_BINDGEN_WEAKREF` feature support to the latest version of the weak references proposal in JS. This also updates the `Closure` type to use finalization registries to ensure closures are deallocated with the JS gc. This means that `Closure::forget` will not actually leak memory in a weakref-using application.
| /// will not leak memory. Instead the Rust memory will be reclaimed when the | ||
| /// JS closure is GC'd. Weak references are not enabled by default since | ||
| /// they're still a proposal for the JS standard. They can be enabled with | ||
| /// `WASM_BINDGEN_WEAKREF=1` when running `wasm-bindgen`, however. |
There was a problem hiding this comment.
Maybe time to make an actual CLI flag, now that these are pretty far down the standards pipeline.
There was a problem hiding this comment.
Do you think it's worth turning this on by default and requiring a flag to turn it off? I'm not actually sure at what point we should do that...
I agree though that at least this should be a CLI flag now.
There was a problem hiding this comment.
I don't think we are at default-on yet. Probably not for a year or so, I'd guess, if ever :-/
alexcrichton
changed the title
|
Just a heads up, this change broke the |
|
Thanks for the report! I'll publish a new release with #2258 to fix this. |
This commit updates the
WASM_BINDGEN_WEAKREFfeature support to thelatest version of the weak references proposal in JS. This also updates
the
Closuretype to use finalization registries to ensure closures aredeallocated with the JS gc. This means that
Closure::forgetwill notactually leak memory in a weakref-using application.